Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make upload size configurable via ENV Vars #150

Open
1letter opened this issue Oct 23, 2024 · 7 comments
Open

Make upload size configurable via ENV Vars #150

1letter opened this issue Oct 23, 2024 · 7 comments

Comments

@1letter
Copy link

1letter commented Oct 23, 2024

If i want to allow upload files greater 1GB i must patch zope.ini and zope.conf inside the container. that is not a handy solution.

i patch the zope.ini in my container image

[server:main]
# set to 3GB upload size
max_request_body_size = 3221225472

and i patch the zope.conf with:

<dos_protection>
    form-memory-limit 3GB
    form-disk-limit 3GB
    form-memfile-limit 4KB
</dos_protection>
@1letter
Copy link
Author

1letter commented Oct 23, 2024

@fredvd @ericof i can't create a branch nor a PR here in the repro. should i fork this repro?

@1letter
Copy link
Author

1letter commented Oct 24, 2024

@ericof mean the "thumb emoji" do a fork ?

@fredvd
Copy link
Member

fredvd commented Oct 24, 2024

1letter What is your proposed fix to make this a configurable parameter in plone-backend?

  • The restrictions of this repo are on purpose more limited/strict than other repositories under plone because this repo generates the example containers, so ai-team/release team / release managers do the modifications here.

  • I'm all for improving the plone-backend/plone-frontend container images, but these container images are still examples and not meant to be the ultimate image setup for any possible use case. Using this image as a FROM source in your own Dockerfile and customise it there for individual projects IS the suggested way and nothing is wrong with that.

At the same time: if these values can be parameterised easily using environment variables, thats a nice win and improvement.

@1letter
Copy link
Author

1letter commented Oct 24, 2024

@fredvd see my patch example above. This can be parameterised per default in the backend image. 3 new parameters and some minor substitutions in the skeleteon templates.

@erral
Copy link
Member

erral commented Nov 8, 2024

@1letter I also think that we need this. Please add a PR and I will be happy to review it.

For instance when creating a new project using cookieplone-templates, we can set the required configuration in a instance.yaml file that then will be used to produce zope.conf and zope.ini, how can we do something similar with this image?

@stevepiercy
Copy link
Contributor

The only people who can write to this repo are members of the Installers Team and GitHub organization Admins. Are these permissions deliberate?

@erral and @fredvd, @1letter lacks permission to write to this repo, so he will need to create a fork and push from there.

@fredvd
Copy link
Member

fredvd commented Nov 8, 2024

Yes, these permissions are deliberate, as this repo has workflows that create official images. Please create a PR from a fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants