From 565d0628da41f06607b6f3289357fd2141117e21 Mon Sep 17 00:00:00 2001 From: Victor Fernandez de Alba Date: Sun, 24 Mar 2024 11:19:56 +0100 Subject: [PATCH 1/3] Missing step in storybook migration --- docs/source/upgrade-guide/index.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/source/upgrade-guide/index.md b/docs/source/upgrade-guide/index.md index d8085abdbe..a9b9648ece 100644 --- a/docs/source/upgrade-guide/index.md +++ b/docs/source/upgrade-guide/index.md @@ -196,6 +196,14 @@ Replace the `.storybook` folder in your project with this one: https://github.com/plone/volto/tree/5605131868689778bbdca0c3003a40cb9f153c1a/packages/generator-volto/generators/app/templates/.storybook +Then update your project's or add-on `scripts` key like: + +```diff +- "storybook": "start-storybook -p 6006", +- "build-storybook": "build-storybook" ++ "storybook": "storybook dev -p 6006", ++ "build-storybook": "storybook build" +``` ```{seealso} [Migration guide from Storybook 6.x to 8.0](https://storybook.js.org/docs/migration-guide/from-older-version) From f97beabf74bcbe370c00edb028ae6948060158a7 Mon Sep 17 00:00:00 2001 From: Victor Fernandez de Alba Date: Sun, 24 Mar 2024 11:21:20 +0100 Subject: [PATCH 2/3] Clog --- packages/volto/news/5913.documentation | 1 + 1 file changed, 1 insertion(+) create mode 100644 packages/volto/news/5913.documentation diff --git a/packages/volto/news/5913.documentation b/packages/volto/news/5913.documentation new file mode 100644 index 0000000000..8325eabcf7 --- /dev/null +++ b/packages/volto/news/5913.documentation @@ -0,0 +1 @@ +Missing step in storybook migration @sneridagh From 3ece37c98c29136efce61d1a1b080e119366873d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?V=C3=ADctor=20Fern=C3=A1ndez=20de=20Alba?= Date: Mon, 25 Mar 2024 09:17:32 +0100 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: Steve Piercy --- docs/source/upgrade-guide/index.md | 2 +- packages/volto/news/5913.documentation | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/source/upgrade-guide/index.md b/docs/source/upgrade-guide/index.md index a9b9648ece..5b4b0c6313 100644 --- a/docs/source/upgrade-guide/index.md +++ b/docs/source/upgrade-guide/index.md @@ -196,7 +196,7 @@ Replace the `.storybook` folder in your project with this one: https://github.com/plone/volto/tree/5605131868689778bbdca0c3003a40cb9f153c1a/packages/generator-volto/generators/app/templates/.storybook -Then update your project's or add-on `scripts` key like: +Finally, in your project's or add-on's {file}`package.json` file, update the `scripts` key with the key/value pairs, as shown in the following diff. ```diff - "storybook": "start-storybook -p 6006", diff --git a/packages/volto/news/5913.documentation b/packages/volto/news/5913.documentation index 8325eabcf7..bb511245ac 100644 --- a/packages/volto/news/5913.documentation +++ b/packages/volto/news/5913.documentation @@ -1 +1 @@ -Missing step in storybook migration @sneridagh +Add missing step in Storybook 6 to 8 migration. @sneridagh