Fix focus visibility for input components in site setup #6544
Conversation
✅ Deploy Preview for plone-components canceled.
|
Abhishek-17h
force-pushed
the
bugfix/fix-focus-visibility-dropdown
branch
from
c0d3290 to
c47d5f2
Compare
Abhishek-17h
force-pushed
the
bugfix/fix-focus-visibility-dropdown
branch
from
c47d5f2 to
039bab3
Compare
|
@stevepiercy @sneridagh can you please provide review on this? |
|
Refs: #6504 |
| ':active': { | ||
| backgroundColor: null, | ||
| backgroundColor: state.isFocused ? '#e5f4fb' : null, |
There was a problem hiding this comment.
@Abhishek-17h out of curiosity, where did you get the colors in this PR? I know we're picky about being consistent with colors, especially to ensure sufficient contrast for accessibility. I don't know where we capture them all in a single place, like a style guide.
Hopefully someone from the @plone/volto-accessibility team can inform me. If this thing does not exist, it might be a good thing to add to our accessibility PLIP #6504.
There was a problem hiding this comment.
I agree with @stevepiercy. I think we at least need documentation with use cases, such as focus and minimal contrast for the main font color, links, and buttons. It could indeed be a nice touch for the PLIP. I'll add a comment to the PLIP.
There was a problem hiding this comment.
@stevepiercy I understand that the Volto team is particular about color choices, which is why I used an existing color from the SelectStyling and applied a lighter version of it. This approach ensures that users can easily differentiate between selected and hovered inputs.
I didn’t use any specific tools to choose the color but made the adjustment to align with accessibility considerations and consistency within the existing design.
There was a problem hiding this comment.
@stevepiercy Thank you for your kind words! I'm glad to contribute to improving Volto. 😊
Co-authored-by: Steve Piercy <[email protected]>
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Fixed missing visible focus for multiple select inputs across components using the SelectStyling widget in Site Setup. The fix ensures proper focus indication for accessibility across all instances of the widget.
Update snapshots to match new UI behavior.
Screenshots after Fix :
Previous behavior is provided in #6348
Closes #6348