You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
highlight_config (dict; optional): Config options for syntax highlighting. highlight_config is a dict with keys:
theme (a value equal to: 'dark', 'light'; optional): Color scheme; default 'light'.
After dash-core-components==1.13, the settings of highlight_config has no effect. This 🪲 appears to be introduced in #871 where one css file (defining both light and dark theme) was changed with another css file defining only a light theme variation.
As stated on another page (https://dash.plotly.com/external-resources#md-syntax-highlight) in the docs, you can override default highlight.js style if you want other than e.g. the current GitHub style, however, I don't think it is intended from dcc point of view that the default dcc provided style needs to be overridden in order for higlight_config to have effect (if so it should be stated close to the highlight_config explanation probably in the documentation).
Good catch @anders-kiaer - that was not intended. We're adding our class hljs-dark for the dark theme, which indicates we need our own version of the dark theme regardless. I guess the easiest (assuming the hljs v10 bump didn't change its internally-applied classes) is to just bring back the .hljs-dark pieces of the pre-871 CSS file.
As stated in the
dcc.Markdown
documentation (https://dash.plotly.com/dash-core-components/markdown) you can useAfter
dash-core-components==1.13
, the settings ofhighlight_config
has no effect. This 🪲 appears to be introduced in #871 where onecss
file (defining bothlight
anddark
theme) was changed with anothercss
file defining only alight
theme variation.As stated on another page (https://dash.plotly.com/external-resources#md-syntax-highlight) in the docs, you can override default
highlight.js
style if you want other than e.g. the current GitHub style, however, I don't think it is intended fromdcc
point of view that the defaultdcc
provided style needs to be overridden in order forhiglight_config
to have effect (if so it should be stated close to thehighlight_config
explanation probably in the documentation).Test case:
gives the same result as when
{"theme": "light"}
.The text was updated successfully, but these errors were encountered: