Add client options to set Spec and ProtocolVersion #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow clients to specify the Spec and ProtocolVersion with client options when using a kwown client. This avoids querying the plugin for the protocol version and specificcation.
|
Can you explain a use case where I would always know the spec and protocol version? |
|
This was an idea for cached plugins. On receiving a plugin we query the plugin and assert the protocol version storing the Spec. When we retrieve the plugin from the cache we know it protocol version and spec so don't require invoking the plugin again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow clients to specify the Spec and ProtocolVersion with client options for use with a known client. This avoids querying the plugin for the protocol version and specification. Spec errors are no longer stored, this allows for transient errors to be retried.