Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(Generate): generate Dropdown before container #862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stonebuzz
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

This PR adjusts the file regeneration process created by fields.
From now on, the files will be generated in two steps:

  • Generation of files related to dropdowns.
  • Generation of files related to containers.

This prevents a fatal error when a container is added to a dropdown created in another container (and not yet generated).

Screenshots (if appropriate):

Copy link
Contributor

@trasher trasher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if fix is confirmed by reporter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regenerate stops working once a block has been created on a Custom Fields associated type
2 participants