Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate build process to use vite #665

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

jsladerman
Copy link
Contributor

before we were just transpiling with tsc, but not really actually bundling the package together. in addition to giving us flexibility for things like plugins, tree-shaking, and general dependency optimization

it also enables using the css prop in design systems components (before it would work inconsistently depending on whether the consuming application had enabled it, so it might work in the console, but not in storybook e.g.)

also fixes a bug with minor bug with ModalWrappers

@jsladerman jsladerman requested a review from a team as a code owner November 26, 2024 06:14
Copy link

linear bot commented Nov 26, 2024

Copy link

Visit the preview URL for this PR (updated for commit 1fad4d2):

https://pluralsh-design--pr665-jake-prod-2932-add-b-09clksoc.web.app

(expires Tue, 03 Dec 2024 06:34:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 784914c934330f8d0a9fd65c68898b3988262b7d

@jsladerman jsladerman changed the title feat: migrate build process to use vite feat!: migrate build process to use vite Nov 26, 2024
@jsladerman jsladerman merged commit 9b66c98 into main Nov 26, 2024
12 checks passed
@jsladerman jsladerman deleted the jake/prod-2932-add-bundler-to-design-system branch November 26, 2024 16:23
@plural-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants