diff --git a/Makefile b/Makefile index fa8150a..0bb8325 100644 --- a/Makefile +++ b/Makefile @@ -9,6 +9,10 @@ build: .PHONY # compiles test: .PHONY # tests the codebase go test ./... +.PHONY: fix +fix: ## fix issues found by linters + golangci-lint run --fix ./... + release-vsn: # tags and pushes a new release @read -p "Version: " tag; \ git checkout main; \ diff --git a/algorithms/graph_test.go b/algorithms/graph_test.go index 1266809..599c3ee 100644 --- a/algorithms/graph_test.go +++ b/algorithms/graph_test.go @@ -22,7 +22,7 @@ func TestDFS(t *testing.T) { return nil } - DFS(1, neighbors, visit) + _ = DFS(1, neighbors, visit) assert.Equal(t, res, []int{1, 2, 4, 3}) } @@ -42,7 +42,7 @@ func TestBFS(t *testing.T) { return nil } - BFS(1, neighbors, visit) + _ = BFS(1, neighbors, visit) assert.Equal(t, res, []int{1, 2, 3, 4}) } diff --git a/containers/set.go b/containers/set.go index 7801da5..22f90b3 100644 --- a/containers/set.go +++ b/containers/set.go @@ -60,7 +60,7 @@ func (s Set[V]) Equal(other Set[V]) bool { return false } - for k, _ := range s { + for k := range s { if !other.Has(k) { return false } @@ -77,7 +77,7 @@ func (s Set[V]) Equal(other Set[V]) bool { // s2.Difference(s1) = {a4, a5} func (s Set[V]) Difference(other Set[V]) Set[V] { new := NewSet[V]() - for v, _ := range s { + for v := range s { if !other.Has(v) { new.Add(v) } @@ -93,7 +93,7 @@ func (s Set[V]) Difference(other Set[V]) Set[V] { // s2.Union(s1) = {a1, a2, a3, a4} func (s Set[V]) Union(other Set[V]) Set[V] { new := ToSet(s.List()) - for v, _ := range other { + for v := range other { new.Add(v) } return new @@ -104,7 +104,7 @@ func Union[V comparable](sets ...Set[V]) Set[V] { // use nested loops for a bit of extra efficiency for _, s := range sets { - for v, _ := range s { + for v := range s { res.Add(v) } } @@ -119,7 +119,7 @@ func Union[V comparable](sets ...Set[V]) Set[V] { // s1.Intersect(s2) = {a2} func (s Set[V]) Intersect(other Set[V]) Set[V] { res := NewSet[V]() - for v, _ := range s { + for v := range s { if other.Has(v) { res.Add(v) } @@ -134,7 +134,7 @@ func Intersect[V comparable](sets ...Set[V]) Set[V] { return res } first, rest := sets[0], sets[1:] - for v, _ := range first { + for v := range first { if lo.EveryBy(rest, func(s Set[V]) bool { return s.Has(v) }) { res.Add(v) } diff --git a/containers/stack_test.go b/containers/stack_test.go index cc3260a..35ab6d0 100644 --- a/containers/stack_test.go +++ b/containers/stack_test.go @@ -33,8 +33,8 @@ func TestStackToList(t *testing.T) { s.Push(2) assert.Equal(t, s.List(), []int{2, 3, 1}) - s.Pop() + _, _ = s.Pop() assert.Equal(t, s.List(), []int{3, 1}) - s.Pop() + _, _ = s.Pop() assert.Equal(t, s.List(), []int{1}) } diff --git a/retry/algorithms.go b/retry/algorithms.go index 148337a..7fcdf7b 100644 --- a/retry/algorithms.go +++ b/retry/algorithms.go @@ -24,11 +24,7 @@ func (exp *Exponential) Backoff(iter int) time.Duration { } func (exp *Exponential) Continue() bool { - if exp.max <= exp.start { - return false - } - - return true + return exp.max > exp.start } type Constant struct {