Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup group client code #26

Open
davidspek opened this issue Apr 14, 2023 · 0 comments
Open

Cleanup group client code #26

davidspek opened this issue Apr 14, 2023 · 0 comments

Comments

@davidspek
Copy link
Contributor

The code in clients/group.go is very inefficient and can be cleaned up a lot. Rather than make a whole bunch of requests to Keto we can perform the entire change set with a single call to c.KetoClient.TransactTuples() with all the tuples that should be added or removed. This is currently what is being done in clients/observabilitytenant.go.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davidspek