Add flight speed

src/item/ItemBlock.php

@@ -24,7 +24,6 @@
 namespace pocketmine\item;
 
 use pocketmine\block\Block;
-use pocketmine\block\BlockTypeIds;
 use pocketmine\data\runtime\RuntimeDataDescriber;
 
 /**
@@ -59,12 +58,4 @@ public function isFireProof() : bool{
 	public function getMaxStackSize() : int{
 		return $this->block->getMaxStackSize();
 	}
-
-	public function isNull() : bool{
-		//TODO: we really shouldn't need to treat air as a special case here
-		//this is needed because the "null" empty slot item is represented by an air block, but there's no real reason
-		//why air should be needed at all. A separate special item type (or actual null) should be used instead, but
-		//this would cause a lot of BC breaks, so we can't do it yet.
-		return parent::isNull() || $this->block->getTypeId() === BlockTypeIds::AIR;
-	}
 }

src/network/mcpe/NetworkSession.php

@@ -953,8 +953,7 @@ public function syncAbilities(Player $for) : void{
 		];
 
 		$layers = [
-			//TODO: dynamic flying speed! FINALLY!!!!!!!!!!!!!!!!!
-			new AbilitiesLayer(AbilitiesLayer::LAYER_BASE, $boolAbilities, 0.05, 0.1),
+			new AbilitiesLayer(AbilitiesLayer::LAYER_BASE, $boolAbilities, $for->getFlightSpeed(), 0.1),
 		];
 		if(!$for->hasBlockCollision()){
 			//TODO: HACK! In 1.19.80, the client starts falling in our faux spectator mode when it clips into a

src/player/Player.php

@@ -183,6 +183,8 @@ class Player extends Human implements CommandSender, ChunkListener, IPlayer{
 	private const MAX_REACH_DISTANCE_SURVIVAL = 7;
 	private const MAX_REACH_DISTANCE_ENTITY_INTERACTION = 8;
 
+	public const DEFAULT_FLIGHT_SPEED = 0.05;
+
 	public const TAG_FIRST_PLAYED = "firstPlayed"; //TAG_Long
 	public const TAG_LAST_PLAYED = "lastPlayed"; //TAG_Long
 	private const TAG_GAME_MODE = "playerGameType"; //TAG_Int
@@ -278,6 +280,8 @@ public static function isValidUserName(?string $name) : bool{
 	protected bool $blockCollision = true;
 	protected bool $flying = false;
 
+	protected float $flightSpeed = self::DEFAULT_FLIGHT_SPEED;
+
 	/** @phpstan-var positive-int|null  */
 	protected ?int $lineHeight = null;
 	protected string $locale = "en_US";
@@ -515,6 +519,17 @@ public function hasAutoJump() : bool{
 		return $this->autoJump;
 	}
 
+	public function setFlightSpeed(float $flightSpeed) : void{
+		if($this->flightSpeed !== $flightSpeed && $flightSpeed >= 0){
+			$this->flightSpeed = $flightSpeed;
+			$this->getNetworkSession()->syncAbilities($this);
+		}
+	}
+
+	public function getFlightSpeed() : float{
+		return $this->flightSpeed;
+	}
+
 	public function spawnTo(Player $player) : void{
 		if($this->isAlive() && $player->isAlive() && $player->canSee($this) && !$this->isSpectator()){
 			parent::spawnTo($player);