feat: add Crimson Nylium and Warped Nylium blocks #6481
Conversation
|
|
||
| class RedMushroom extends Flowable{ | ||
| use StaticSupportTrait; |
There was a problem hiding this comment.
Apply only minimal change, this is unrelated to the PR "add Crimson Nylium".
Open an other PR if you want to change that.
There was a problem hiding this comment.
This isn't resolved, you still add the use of StaticSupportTrait
|
Bonemeal logic is missing. Also, this PR should target |
|
There is no block available for bone meal spreading, roots and fungus is missing |
Roots are implemented. https://github.com/pmmp/PocketMine-MP/blob/stable/src/block/NetherRoots.php |
jasonw4331
added
Category: Gameplay
| class NetherGrass{ | ||
| public static function growGrass(ChunkManager $world, Vector3 $pos, Random $random, int $count = 8, int $radius = 5) : void{ |
There was a problem hiding this comment.
As there is no nether generator, I don't see the point of including a single function in a new class in the generator objects.
|
|
||
| class RedMushroom extends Flowable{ | ||
| use StaticSupportTrait; |
There was a problem hiding this comment.
This isn't resolved, you still add the use of StaticSupportTrait
| $world = $this->position->getWorld(); | ||
| if($item instanceof Fertilizer){ | ||
| $item->pop(); | ||
| NetherGrass::growGrass($world, $this->position, new Random(mt_rand()), 8, 2); |
There was a problem hiding this comment.
What's the point of integrating all the logic into a specific function that's only used once?
Introduction
Crimson NyliumandWarped Nyliumblocks addedTests
I tested this PR by doing the following (tick all that apply):
tests/phpunitfolder)