Implemented the correct walking speed for the slime block #6529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dktapps
requested changes
Nov 23, 2024
| $entity->setMotion($motion->multiply($this->speedMultiplier)); | ||
| } | ||
|
|
||
| public function setSpeedMultiplier(float $multiplier) : void{ |
There was a problem hiding this comment.
You can't set this. Block objects aren't persistent.
There was a problem hiding this comment.
If this is really needed, you should do it across events
There was a problem hiding this comment.
It's not reliable under any conditions as the cache for blocks may be destroyed any time. We don't have setters for any other type-level properties like this. Unless this was stored in a blockstate property or tile property, it will just vanish and you'll be none the wiser why it doesn't work.
| @@ -40,5 +42,19 @@ public function onEntityLand(Entity $entity) : ?float{ | |||
| return -$entity->getMotion()->y; | |||
| } | |||
|
|
|||
| //TODO: slime blocks should slow entities walking on them to about 0.4x original speed | |||
| public function onEntityWalking(Entity $entity) : void{ | |||
There was a problem hiding this comment.
This isn't going to magically work. Nothing is going to call it.
dktapps
added
Category: Gameplay
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the default walking speed of (0.4) as the “TODO” suggest and added new methods to modify the walking speed or get the walking speed of the slime block.
I sorta guessed what that “TODO” meant.