Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Term messages in Agreement and enabled early termination #56

Merged
merged 2 commits into from
Jun 8, 2018

Conversation

vkomenda
Copy link
Contributor

@vkomenda vkomenda commented Jun 7, 2018

Close #55

A terminated instance continues handling messages after termination according to the previous semantics of termination. However a Term message is sent only once.

@vkomenda vkomenda requested a review from afck June 7, 2018 19:16
Copy link
Collaborator

@afck afck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍
(I was just about to write that we mustn't count nodes twice, but you ninja'd me! 😁 )

epoch,
content: self,
}
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, that's much more concise! 👍

@afck
Copy link
Collaborator

afck commented Jun 7, 2018

Looks like Travis failed to download protoc. Probably some connection issue; retrying…

@vkomenda vkomenda merged commit d1362ed into master Jun 8, 2018
@vkomenda vkomenda deleted the vk-term-agreement branch June 13, 2018 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants