ProcessRunner does not detect launch errors #4482
Milestone
Comments
aleks-f
added a commit
that referenced
this issue
Mar 5, 2024
aleks-f
added a commit
that referenced
this issue
Mar 6, 2024
matejk
pushed a commit
that referenced
this issue
May 20, 2024
matejk
pushed a commit
that referenced
this issue
May 20, 2024
aleks-f
added a commit
that referenced
this issue
Jul 29, 2024
* enh(ProcessRunner): does not detect launch errors #4482 * enh(File): add absolutePath and existsAnywhere() #4482 * fix windows build and tsan fail * fix tsan * fix windows file tests * comment out some CI env path -related issues * fix tsan and windows build * try to fix ci * ignore ProcessRunner test fail on windows cmake * enh(File): canExecute throws FileNotFoundException if the file to be executed can't be found in the path. * Few C++ modernisation changes. * enh(File): Windows specifics of File::canExecute. Returns false if the file to be executed can't be found using absolutePath. --------- Co-authored-by: Matej Kenda <[email protected]>
|
Fixed in #4483 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Launch thread silently ignores any errors or exceptions.
To Reproduce
Launch a non-existing executable.
EDIt: there seems to be no reliable portable way to detect what exactly happens with the launched process (not even when the executable does not exist). Seems best to add the executable file existence check which includes
cwdand environment path, and not even try to launch a non-existent executable.The text was updated successfully, but these errors were encountered: