Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data: warning: 'isNull' overrides a member function but is not marked 'override' #4768

Open
matejk opened this issue Nov 13, 2024 · 0 comments

Comments

@matejk
Copy link
Contributor

matejk commented Nov 13, 2024

Describe the bug

clang reports warnings when compiling.

Logs

Compiler output:

[1051/1178 10.3/sec] Building CXX object Data/testsuite/CMakeFiles/Data-testrunner.dir/src/DataTest.cpp.o
In file included from /Users/matejk/git/github/poco/Data/testsuite/src/DataTest.cpp:12:
/Users/matejk/git/github/poco/Data/testsuite/src/Extractor.h:422:7: warning: 'isNull' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  422 |         bool isNull(std::size_t col, std::size_t row = -1);
      |              ^
/Users/matejk/git/github/poco/Data/include/Poco/Data/AbstractExtractor.h:431:15: note: overridden virtual function is here
  431 |         virtual bool isNull(std::size_t col, std::size_t row = POCO_DATA_INVALID_ROW) = 0;
      |                      ^
In file included from /Users/matejk/git/github/poco/Data/testsuite/src/DataTest.cpp:12:
/Users/matejk/git/github/poco/Data/testsuite/src/Extractor.h:425:7: warning: 'reset' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  425 |         void reset();
      |              ^
/Users/matejk/git/github/poco/Data/include/Poco/Data/AbstractExtractor.h:434:15: note: overridden virtual function is here
  434 |         virtual void reset();
      |                      ^
2 warnings generated.

Please add relevant environment information:

  • macOS 15.0.1
  • POCO Version: 1.14 (pre-release)
@matejk matejk added the bug label Nov 13, 2024
@matejk matejk added this to the Release 1.14.0 milestone Nov 13, 2024
@matejk matejk added this to 1.14 Nov 13, 2024
@aleks-f aleks-f moved this to In Progress in 1.14 Nov 14, 2024
@aleks-f aleks-f self-assigned this Nov 14, 2024
@aleks-f aleks-f added development and removed bug labels Nov 14, 2024
@aleks-f aleks-f moved this from In Progress to Done in 1.14 Nov 14, 2024
@aleks-f aleks-f added the fixed label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants