Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update HTTPSClientSession.h #715

Merged
merged 1 commit into from
Feb 19, 2015
Merged

Update HTTPSClientSession.h #715

merged 1 commit into from
Feb 19, 2015

Conversation

MattPD
Copy link
Contributor

@MattPD MattPD commented Feb 18, 2015

Fix typo in the class documentation.

@MattPD
Update HTTPSClientSession.h
170d74b 
Fix typo in the documentation.
@aleks-f aleks-f closed this Feb 19, 2015
@MattPD
Copy link
Contributor Author

MattPD commented Feb 19, 2015

One quick note: There were three similarly named files (one HTTPClientSession.h -- and two HTTPSClientSession.h) affected by this (now two remaining) -- thus three patches: https://github.com/pocoproject/poco/search?utf8=%E2%9C%93&q=sendRequst

@aleks-f aleks-f removed the duplicate label Feb 19, 2015
@aleks-f aleks-f reopened this Feb 19, 2015
aleks-f added a commit that referenced this pull request Feb 19, 2015
@aleks-f
Merge pull request #715 from MattPD/patch-4
05b409a 
Update HTTPSClientSession.h
@aleks-f aleks-f merged commit 05b409a into pocoproject:develop Feb 19, 2015
@aleks-f
Copy link
Member

aleks-f commented Feb 19, 2015

Sorry, in a rush I thought those were duplicates. They are merged now.

@MattPD
Copy link
Contributor Author

MattPD commented Feb 19, 2015

No worries! Incidentally, I could use a workflow advice -- what's the recommended / best practice for deleting branches after PR (referring to GitHub's message "branch can be safely deleted")?

Delete or keep it around (I presume it depends on whether the "unknown repository" showing up as the origin is an issue or not: isaacs/github#168)?

@aleks-f
Copy link
Member

aleks-f commented Feb 19, 2015

Expecting people to keep forever the pulled-from repository is not feasible; there's no way for us to control what people do. And it doesn't really matter IMO because all the relevant changes/commits are recorded in the pull.

@MattPD
Copy link
Contributor Author

MattPD commented Feb 19, 2015

OK, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattPD @aleks-f