Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable ABI support #3422

Closed
3 tasks done
mishashemin opened this issue Oct 2, 2024 · 1 comment
Closed
3 tasks done

Stable ABI support #3422

mishashemin opened this issue Oct 2, 2024 · 1 comment

Comments

@mishashemin
Copy link

Description

Hello, we are using TCA in our sdk for distribution.
The SDK is being built into a single static framework with swift-evolution support.

Until recently, everything was fine, but we had to update version 1.12.1 -> 1.15.0 to support xcode 16.
After this update, our framework stopped being built due to xctest-dynamic-overlay

/.build/SourcePackages/checkouts/xctest-dynamic-overlay/Sources/IssueReporting/ReportIssue.swift:37:3: error: switch covers known cases, but 'TestContext?' may have additional unknown values, possibly added in future versions
  switch TestContext.current {
  ^
/build/.build/SourcePackages/checkouts/xctest-dynamic-overlay/Sources/IssueReporting/ReportIssue.swift:37:3: note: add missing cases
  switch TestContext.current {
  ^

Please fix this problem. As a temporary measure, we had to turn off support for swift-evolution, but we really want to bring it back.

Checklist

  • I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
  • If possible, I've reproduced the issue using the main branch of this package.
  • This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior

No errors when building the framework with the BUILD_LIBRARY_FOR_DISTRIBUTION flag enabled

Actual behavior

Errors when building a framework with the BUILD_LIBRARY_FOR_DISTRIBUTION flag enabled

Reproducing project

No response

The Composable Architecture version information

1.15.0

Destination operating system

No response

Xcode version information

No response

Swift Compiler version information

No response

@mishashemin mishashemin added the bug Something isn't working due to a bug in the library. label Oct 2, 2024
@mbrandonw
Copy link
Member

Hi @mishashemin, the issue has been fixed (see pointfreeco/swift-issue-reporting#133), but just not released yet. We will do that later today.

Also, just want to remind you that we do not guarantee ABI stability in any of our libraries. At the request of some of users we have made changes to our libraries to make sure it builds with library evolution turned on, but it's a "use at your own risk" kind of situation. You will need to recompile the library from scratch anytime you update. Just want to make sure that's clear.

Since this isn't an issue with the library I am going to convert it to a discussion. Please feel free to continue the conversation over there!

@mbrandonw mbrandonw removed the bug Something isn't working due to a bug in the library. label Oct 2, 2024
@pointfreeco pointfreeco locked and limited conversation to collaborators Oct 2, 2024
@mbrandonw mbrandonw converted this issue into discussion #3423 Oct 2, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants