Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unimplemented without Void placeholder produces deprecation warning #122

Closed
hyperspacemark opened this issue Aug 24, 2024 · 1 comment
Closed

Comments

@hyperspacemark
Copy link

The following declaration produces a deprecation warning on the Swift 6 language mode only. I'm aware that the placeholder-less methods were deprecated but this seems to have only appeared after #114 was released.

var onCancel: () -> Void = unimplemented("ViewModel.onCancel") // warning: 'unimplemented(_:file:fileID:function:line:)' is deprecated: renamed to 'unimplemented(_:placeholder:)'

I can of course resolve the warning with the following but I don't think the intention is that this is necessary.

var onCancel: () -> Void = unimplemented("ViewModel.onCancel", placeholder: ())
@stephencelis
Copy link
Member

This should be fixed by #123! We'll do a release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants