-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would you kindly replace 2nd confirm with exit module button ~ Marie #530
Comments
I think we agreed this would be best to have the modals close after they finish updating. Although, we still don't see where the bug came from, as submitting a link is not a modal. |
So, this came up again, from the flair submission modal (From Marie) I really don't like Marie's solution of turning the submit button into a close button, as changing what a button does is also really confusing. However, I have 2 suggestions:
Thoughts, guys? I would be happy with either of these suggestions. Once we've got gen 7 and a bit of legality done on porybox, I'd like to come back to flairhq for a bit to get some of these niggles sorted. |
Option 1 is probably the most logical. |
I need more context on this. What is the "something" we are submitting? |
So, specifically it is flair text. There might be others, but I don't think there are. |
After you submit something, the checkmark button tries to submit the thing again instead of closing the window. So then it gives you a pop-up saying "you just submitted this, error" or something. Really awkward UI there.
There's only a "cancel" and the "confirm" button after submitting the changes, which makes it rather redundant and a little confusing. Once submitted, the confirm button should be an exit button or it should just close automatically.
~ From SaberMarie
The text was updated successfully, but these errors were encountered: