Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proof & Claim Windows] Publish on-chain events from Claim & Proof Windows #580

Closed
3 of 8 tasks
Olshansk opened this issue Jun 4, 2024 · 0 comments · Fixed by #629
Closed
3 of 8 tasks

[Proof & Claim Windows] Publish on-chain events from Claim & Proof Windows #580

Olshansk opened this issue Jun 4, 2024 · 0 comments · Fixed by #629
Assignees
Labels
on-chain On-chain business logic protocol General core protocol related changes

Comments

@Olshansk
Copy link
Member

Olshansk commented Jun 4, 2024

Objective

Provide persistent on-chain visibility into Claim & Proof windows

Origin Document

Screenshot 2024-06-03 at 8 37 35 PM
Screenshot 2024-06-03 at 8 36 22 PM

Goals

  • Enable indexers and users to get visibility into on-chain Claims & Proofs (present & past)

Deliverables

  • Introduce new types for on-chain Claim & Proof events
  • Emit the types above at the appropriate time
  • Update / add E2E tests to wait / listen on these wait appropriate
  • Optional: Add a dashboard in grafana to get visibility into these

Non-goals / Non-deliverables

  • Changing business logic around opening / closing Claim & Proof windows

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @Olshansk
Co-Owners: @bryanchriswhite

@Olshansk Olshansk added protocol General core protocol related changes proxy Changes related to the Proxy on-chain On-chain business logic and removed proxy Changes related to the Proxy labels Jun 4, 2024
@Olshansk Olshansk added this to Shannon Jun 4, 2024
@Olshansk Olshansk moved this to 🔖 Ready in Shannon Jun 4, 2024
@Olshansk Olshansk added this to the Shannon Beta TestNet Launch milestone Jun 4, 2024
@bryanchriswhite bryanchriswhite moved this from 🔖 Ready to 🏗 In progress in Shannon Jun 20, 2024
@bryanchriswhite bryanchriswhite linked a pull request Jun 20, 2024 that will close this issue
14 tasks
@bryanchriswhite bryanchriswhite moved this from 🏗 In progress to 👀 In review in Shannon Jun 28, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Shannon Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-chain On-chain business logic protocol General core protocol related changes
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants