Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Foundation] Add gas fees #794

Open
6 tasks
Olshansk opened this issue Sep 4, 2024 · 6 comments
Open
6 tasks

[Foundation] Add gas fees #794

Olshansk opened this issue Sep 4, 2024 · 6 comments
Assignees
@okdas
Labels
on-chain On-chain business logic
Milestone
Shannon Beta Test...

Comments

@Olshansk
Copy link
Member

Olshansk commented Sep 4, 2024

Objective

Add transaction/gas fees to poktroll.

Origin Document

https://docs.cosmos.network/main/learn/beginner/gas-fees

https://www.notion.so/buildwithgrove/Proof-submission-cost-Tx-fee-vs-Spend-coins-044bcab72c1d4aef8dba523bd9bdf42d?pvs=4

Screenshot 2024-09-04 at 3 03 48 PM

Screenshot 2024-09-04 at 3 01 53 PM

Goals

  • Parity with Morse w.r.t Tx Fees
  • Unblock poktscan from deserializing tx fees
  • Learning & understanding how cosmos gas fees work

Deliverables

  • Set a constant tx fee for all transactions
  • Ensure this is part of LocalNet and future TestNets

Non-goals / Non-deliverables

  • Using variable gas meter logic

General deliverables

  • Comments: Add/update TODOs and comments alongside the source code so it is easier to follow.
  • Testing: Add new tests (unit and/or E2E) to the test suite.
  • Makefile: Add new targets to the Makefile to make the new functionality easier to use.
  • Documentation: Update architectural or development READMEs; use mermaid diagrams where appropriate.

Creator: @Olshansk
Co-Owners: @okdas
@Olshansk Olshansk added the on-chain On-chain business logic label Sep 4, 2024
@Olshansk Olshansk added this to the Shannon Beta TestNet Launch milestone Sep 4, 2024
@Olshansk Olshansk added this to Shannon Sep 4, 2024
@okdas
Copy link
Member

okdas commented Sep 4, 2024

@Olshansk I've added the gas fees in #768. They're not constant, though. I can look into that to see if constant fees can be easily configured.

@okdas
Copy link
Member

okdas commented Sep 5, 2024

I flipped the config temporarily in TestNet, and

  • faucet broke as it required a fee configuration. Error: 
    err: Error: Broadcasting transaction failed with code 13 (codespace: sdk). Log: insufficient fees; got:  required: 1upokt: insufficient fee
  • All CLI commands that we have in documentation also stopped working due to a similar issue. So we either need to change the documentation or CLI defaults.

Will take a look at both when I start working on the ticket.

@Olshansk Olshansk moved this to 🏗 In progress in Shannon Sep 6, 2024
@Olshansk
Copy link
Member Author

Olshansk commented Sep 6, 2024

@okdas Once you take a look at it, let's go with CLI defaults (if it's possible) and just document the flag in the user guide in one spot.

This was referenced Sep 9, 2024
Merged
Closed
okdas added a commit that referenced this issue Sep 9, 2024
@okdas @Olshansk
[Quick PR][LocalNet] Turn off minimum-gas-prices (#805)
56dc09f 
## Summary

`minimum-gas-prices` was increased to `0.000000001upokt` on LocalNet. We
are not ready for that yet. #794 will address the default fees values,
so all existing documentation and processes will continue working with
non-zero gas prices.

---------

Co-authored-by: Daniel Olshansky <[email protected]>
@okdas
Copy link
Member

okdas commented Sep 17, 2024

Related doc: https://www.notion.so/buildwithgrove/Proof-submission-cost-Tx-fee-vs-Spend-coins-044bcab72c1d4aef8dba523bd9bdf42d?pvs=4

okdas added a commit that referenced this issue Nov 14, 2024
@okdas @Olshansk
[Quick PR][LocalNet] Turn off minimum-gas-prices (#805)
9e8aa58 
## Summary

`minimum-gas-prices` was increased to `0.000000001upokt` on LocalNet. We
are not ready for that yet. #794 will address the default fees values,
so all existing documentation and processes will continue working with
non-zero gas prices.

---------

Co-authored-by: Daniel Olshansky <[email protected]>
@okdas okdas mentioned this issue Nov 18, 2024
Closed
7 tasks
@okdas okdas changed the title [Foundation] Add constant gas fees [Foundation] Add gas fees Nov 18, 2024
@okdas
Copy link
Member

okdas commented Nov 18, 2024

We've decided we are not going to add a constant gas fee. However, we still need to adjust minimum-gas-prices on our networks to make sure we don't miss anything gas related. Will prioritize this in preparation for beta testnet and #925.

@okdas okdas mentioned this issue Nov 21, 2024
Draft
15 tasks
@okdas
Copy link
Member

okdas commented Dec 2, 2024 •
edited
Loading

Beta TestNet has been running with the fees turned on, and we're working to add them on LocalNet in #940.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@okdas okdas

Labels
on-chain On-chain business logic
Projects
Shannon
Status: 🏗 In progress
Milestone
Shannon Beta TestNet Support
Development

No branches or pull requests
2 participants
@Olshansk @okdas