Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Services with similar functions #14

Open
balkamm opened this issue May 15, 2012 · 5 comments
Open

Multiple Services with similar functions #14

balkamm opened this issue May 15, 2012 · 5 comments

Comments

@balkamm
Copy link

balkamm commented May 15, 2012

If you define multiple services in one thrift file with functions in each that have the same name, there are name collisions with some of the helper structs which prevent the whole from building.

@pomack
Copy link
Owner

pomack commented May 15, 2012

This is a known limitation of the current thrift4go compiler and one of the main reasons I haven't tried pushing this to the official Apache project. It will require adding in proper referencing, but I haven't had the time to look into this.

If you have the time, I can point you in the right direction, otherwise I can't get to this until June at the earliest.

@balkamm
Copy link
Author

balkamm commented May 15, 2012

I'll take a look at this in the next few weeks if I get a chance. For the time being I just changed it to two different files. I guess I'm surprised to hear that you haven't pushed to the official project since it appears to be baked into thrift 0.8

@pomack
Copy link
Owner

pomack commented May 15, 2012

The last version I pushed to the official Apache Thrift project was for Go 0.6x. The Go 1.0 release required a large number of changes, which I at least haven't pushed to the official Apache Thrift project.

@dmuir
Copy link

dmuir commented Jul 30, 2012

What is the status of pushing back to the official Thrift project? It seems like what you have here is better than what ships with the 0.8 release.

@pomack
Copy link
Owner

pomack commented Aug 5, 2012

matttproud said he sent a pull request for the official Thrift project. I never followed up with that due to lack of time. I have been integrating his and others' changes into this repository as they send it to me. This repository is in better shape than what ships with the 0.8 release. There are a few more things I'd like fixed, but those are also issues in the 0.8 version. This version has support for Go 1.0, whereas the 0.8 version currently does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants