Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to skip fetching all stargazers #15

Open
anuraghazra opened this issue Oct 14, 2023 · 1 comment
Open

feat: add ability to skip fetching all stargazers #15

anuraghazra opened this issue Oct 14, 2023 · 1 comment

Comments

@anuraghazra
Copy link

As pointed out in this tweet, if you have many stars fetching all the content takes quite a while, and it could also hit a rate limit on github API.

And for a 15sec video maybe it won't even be that noticeable if say we try to render all unique 60k stargazers,
Instead we can add a flag or a "maxFetchCount" param to limit the fetch and after a while the video can just loop over or randomly pick stargazers in the middle to pad out the 15sec.


For this to work I think a better approach would be:

Say I have 50k stars:

  • We fetch first 10k stargazers
  • Pad out the middle with random stargazers
  • We fetch last 10k stargazers

We put these first/last stargazers as is so that the order is accurate in the video, and in the middle we can pad the stargazers by randomly picking stargazers.

LMK if this is something you will be interested in or you think it's worth adding.

@JonnyBurger
Copy link
Collaborator

I think it is pretty rare that one has as many stars as you (congrats! 😛)
And you still got it rendered, albeit taking some time.

Therefore it is not a priority for me personally but happy to accept PRs improving this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants