Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Sierra not supported #2

Open
sparky672 opened this issue Jul 19, 2017 · 13 comments
Open

Latest Sierra not supported #2

sparky672 opened this issue Jul 19, 2017 · 13 comments

Comments

@sparky672
Copy link

Getting an "unsupported OS" error on latest version of Sierra released today.

10.12.6 (16G29)

@phtmgt
Copy link

phtmgt commented Jul 19, 2017

Does not work on High Sierra Beta 2 either.

@pookjw
Copy link
Owner

pookjw commented Jul 20, 2017

@sparky672 sorry i'm busy now. I'll upload patch file today.

@pookjw
Copy link
Owner

pookjw commented Jul 20, 2017

@finkbg upload Terminal screen picture!

@pookjw
Copy link
Owner

pookjw commented Jul 20, 2017

@sparky672 now supports 16G29

@phtmgt
Copy link

phtmgt commented Jul 20, 2017

Terminal finishes process fine. Once the system reboots there is no notification panel and night Shift is not working as before. Once I restore the backup the notifications panel immediately appears.

@aonez
Copy link

aonez commented Jul 20, 2017

@finkbg can you try with this one? Just baked it, use it at your own risk. Use it with sudo and SIP disabled.

Worked for me on 10.12.6 update. Not tested on 10.13.x.

@pookjw
Copy link
Owner

pookjw commented Jul 20, 2017

@finkbg Works well on macOS High Sierra Public Beta 2. Seems like your Mac's binaries are broken.

Imgae

@pookjw
Copy link
Owner

pookjw commented Jul 20, 2017

@aonez Works well on macOS High Sierra Develper Beta 3. Great idea.

NightShiftPatcher by aONe ® 2017 (https://github.com/aonez)
Original idea by Pike (https://pikeralpha.wordpress.com/2017/01/30/4398)
Based on NightPatch (https://github.com/pookjw/NightPatch)

Cloning CoreBrightness...
Looking for minimum requirements check offset...
Offset: 0x200a0
Getting offset hex data...
Original hex: 000200a0: 0900 0000 0d00 0000 0600 0000 0500 0000 0600 0000 0800 0000 ........................
Replacing offset hex data...
24+0 records in
24+0 records out
24 bytes transferred in 0.000238 secs (100865 bytes/sec)
Checking offset hex replaced...
Replaced hex: 000200a0: 0100 0000 0100 0000 0100 0000 0100 0000 0100 0000 0100 0000 ........................
Creating a backup...
cp: /Users/aone/Desktop/core.bak: No such file or directory
Replacing CoreBrightness with patched one...
Resigning kext...
/System/Library/PrivateFrameworks/CoreBrightness.framework/Versions/A/CoreBrightness: replacing existing signature

All done now :)

@aonez
Copy link

aonez commented Jul 20, 2017

Thanks @pookjw! Being using your patch for some time now, just wanted to see if an "all-time" patch can be made, so it is not necessary to release a new patch version on every macOS update.

You can use the code if you like to. Let me know if you do so then I'll no longer improve mine.

@sparky672
Copy link
Author

sparky672 commented Jul 20, 2017

@sparky672 Works well on macOS High Sierra Public Beta 2. Seems like your Mac's binaries are broken.

What are you talking about?? I'm using Sierra 10.12.6 (16G29) that was released yesterday.

No Beta. Not High Sierra.

@pookjw
Copy link
Owner

pookjw commented Jul 20, 2017

@sparky672 oops,Sorry! 16G29 is now supported and that's my mistake.

@pookjw
Copy link
Owner

pookjw commented Jul 20, 2017

@aonez I'll add your code to NightPatch soon. Thanks. :)

@phtmgt
Copy link

phtmgt commented Jul 26, 2017

Ok, aonez's solution now confirmed to be working even on latest high sierra beta (developer 4/public 3). Issue with my system seems to have been missing xcode tools (xcrun?).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants