Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter doc #1

Open
JuliusSustarevas opened this issue Jul 18, 2019 · 6 comments
Open

Parameter doc #1

JuliusSustarevas opened this issue Jul 18, 2019 · 6 comments
Assignees

Comments

@JuliusSustarevas
Copy link

Hi
Could you add a doc on what the parameters are? What units they are in for example, its not always clear. The references you provided help but the first one doesn't load. Would appreciate the help, thanks.

@pooyanjamshidi
Copy link
Owner

@JuliusSustarevas Please refer to this.

@JuliusSustarevas
Copy link
Author

Yes, the link 1 is not loading tho it seems to be just Ohms law, the rest do not go through how you modelled the battery. Specifically what are the smooth_current_tau, linear_coef and constant_coef. Thanks for your help int he matter.

@mgerhardt10
Copy link

mgerhardt10 commented Jun 11, 2020

@mgerhardt10
Copy link

mgerhardt10 commented Jun 11, 2020

@JuliusSustarevas

Reading through the code, here's what I've come up with for discharging:

image
image

Note: dt is a Gazebo param and defaults to 0.001

image
Initial Values:
q = q0 = initialCharge

I hope I didn't miss anything

@pooyanjamshidi
Copy link
Owner

@mgerhardt10 I cannot see the images you put in there, could you please check them out?

@mgerhardt10
Copy link

@mgerhardt10 I cannot see the images you put in there, could you please check them out?

I'm able to see them if I click the image link. For reference, they're just the equations from your discharge_battery.cpp file

@pooyanjamshidi pooyanjamshidi self-assigned this Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants