Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single-click on server-side decorations causes window to enter drag mode #1071

Open
ryanabx opened this issue Dec 17, 2024 · 3 comments
Open

Comments

@ryanabx
Copy link
Contributor

ryanabx commented Dec 17, 2024

Probably the worst demonstration of all time, but here:

Let me know if this is a duplicate issue!

2024-12-16.21-50-02.mp4
@ids1024
Copy link
Member

ids1024 commented Dec 17, 2024

I think it detects the start of a drag based on a threshold of a certain number of pixels moved after the click, so maybe that number should be increased. (Or I don't know if there are other checks that other implementations use.)

@ryanabx
Copy link
Contributor Author

ryanabx commented Dec 17, 2024

I was clicking, then lifting my mouse click without moving my mouse at all, which was what struck out to me. If it's calculating a threshold, yeah it definitely should be increased.

I don't know how other implementations work for sure, but if the mouse is lifted it probably shouldn't keep the drag going

@ids1024
Copy link
Member

ids1024 commented Dec 17, 2024

Oh yeah, it shouldn't keep dragging after lifting the mouse. That should cancel the mouse grab and stop the drag.

Probably something #1046 broke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants