WIP atspi: add_virtual_modifier
#982
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drakulix
reviewed
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pop-os/cosmic-protocols#41, pop-os/at-spi2-core#1.
There seems to be a race condition in Orca where it removes all key grabs, then adds a new set of key grabs. As this previously worked, this briefly removed the virtual modifier, which could result in a keypress being sent. (Which could send a caps lock.)
I need to do more testing, and see how other things are working and what other improvements may help, but this seems like a good idea. The virtual modifier is added once at the start.
The fact key input can race with orca/compositor changes to grabs seems bad in general, but I guess that's a limitation of how
AtspiDeviceis currently designed.