Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid proportions #577

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Handle invalid proportions #577

merged 1 commit into from
Nov 25, 2024

Conversation

molpopgen
Copy link
Collaborator

See #576

@molpopgen
Copy link
Collaborator Author

CI is broken. Gotta fix that first....

@grahamgower
Copy link
Member

It looks like the runner is trying to execute:

pip install --upgrade pip pip install -r requirements.txt

Which kinda makes sense in light of the error message:

ERROR: Could not find a version that satisfies the requirement install (from versions: none)
ERROR: No matching distribution found for install

That part of the .yml files hasn't changed, but maybe there's a newline issue here that is newly problematic? Mixed dos/unix newlines?

@molpopgen
Copy link
Collaborator Author

@grahamgower -- I think some of the issue has to do w/the CI being quite out of date. I saw similar errors in the demes-spec PRs before the CI there got updated.

@grahamgower
Copy link
Member

The docs build seems to be working here. It's also working for me offline, with Python 3.11. Maybe just rebase this and apply fixes for the proportions? We can do the update to Python 3.12 separately.

@molpopgen molpopgen force-pushed the handle_invalid_proportions branch from 26b79bd to 978b1a5 Compare November 22, 2024 17:38
@molpopgen molpopgen mentioned this pull request Nov 22, 2024
@molpopgen molpopgen force-pushed the handle_invalid_proportions branch from 978b1a5 to 9774946 Compare November 25, 2024 21:24
* update demes-sped
@molpopgen molpopgen force-pushed the handle_invalid_proportions branch from e506b73 to b579855 Compare November 25, 2024 22:28
Copy link
Member

@grahamgower grahamgower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@grahamgower
Copy link
Member

Oooh, codecov isn't broken, it really is just overloaded!

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (1c38a2f) to head (b579855).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #577   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files           5        5           
  Lines        1597     1600    +3     
=======================================
+ Hits         1594     1597    +3     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@molpopgen
Copy link
Collaborator Author

@grahamgower -- I made the minimal changes needed for tests to pass. codecov is still failing.

@grahamgower grahamgower merged commit 83c5ad1 into main Nov 25, 2024
13 of 15 checks passed
@molpopgen molpopgen deleted the handle_invalid_proportions branch November 25, 2024 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants