-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle invalid proportions #577
Conversation
CI is broken. Gotta fix that first.... |
It looks like the runner is trying to execute:
Which kinda makes sense in light of the error message:
That part of the .yml files hasn't changed, but maybe there's a newline issue here that is newly problematic? Mixed dos/unix newlines? |
@grahamgower -- I think some of the issue has to do w/the CI being quite out of date. I saw similar errors in the demes-spec PRs before the CI there got updated. |
The docs build seems to be working here. It's also working for me offline, with Python 3.11. Maybe just rebase this and apply fixes for the proportions? We can do the update to Python 3.12 separately. |
26b79bd
to
978b1a5
Compare
978b1a5
to
9774946
Compare
* update demes-sped
e506b73
to
b579855
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Oooh, codecov isn't broken, it really is just overloaded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 5 5
Lines 1597 1600 +3
=======================================
+ Hits 1594 1597 +3
Misses 3 3 ☔ View full report in Codecov by Sentry. |
@grahamgower -- I made the minimal changes needed for tests to pass. codecov is still failing. |
See #576