Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CI #579

Merged
merged 1 commit into from
Nov 25, 2024
Merged

fix CI #579

merged 1 commit into from
Nov 25, 2024

Conversation

molpopgen
Copy link
Collaborator

No description provided.

@grahamgower
Copy link
Member

There are three distinct issues here. I fixed the dev-deps problem over in #580. There's a second issue with moving to python 3.12, relating to a Warning in a test. The third issue is intersphinx.

@molpopgen, do you want to take care of the python 3.12 problem, and I'll take a look at intersphinx?

@molpopgen
Copy link
Collaborator Author

@molpopgen, do you want to take care of the python 3.12 problem, and I'll take a look at intersphinx?

I'll plug away at it some more. It is a bit of a frustrating one and I need to evaluate the various possible solutions.

* bump to py3.9 in tests
@molpopgen
Copy link
Collaborator Author

@grahamgower -- I reset this one back to main and then bumped the macos runner and py versions for the tests. CI in #577 is not starting due to the old macos runner.

@molpopgen
Copy link
Collaborator Author

@grahamgower -- other than codecov this seems to be working. The macos update seems necessary for other PR.

@grahamgower grahamgower merged commit 4eb5273 into main Nov 25, 2024
7 of 13 checks passed
@grahamgower
Copy link
Member

Ok, thanks. I tried rerunning the tests again, but codecov is still failing to upload. I guess the codecov error is wrong and maybe we need to bump that too.

@molpopgen molpopgen deleted the fix_CI branch November 25, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants