Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urgent: impacts core function usability with no workaround #23

Open
sparklc opened this issue Sep 11, 2021 · 0 comments
Open

Urgent: impacts core function usability with no workaround #23

sparklc opened this issue Sep 11, 2021 · 0 comments

Comments

@sparklc
Copy link

sparklc commented Sep 11, 2021

First one
That's a big one for me, it is up to you guys if you going to understand how important it is, how much it has impact on proper media share, and actual consumption of your product.
Stop using hash # in your URLs, at least avoid doing it as much as possible.

  1. It impacts how people can share links with their friends.
  2. It impacts how other crawling engines can browse and take a screenshot for your pages.
    a) Try linking on twitter https://mainnet.port.finance/#/markets and https://mainnet.port.finance/#/dashboard, it is a different page that should be displayed, but the systems will pick up only the default one before the hash tag. Maybe not the best example with twitter, but I hope you get what I mean.
    Please understand I don't want to discredit the developers practices, but It is just a bad practice.

Second one
screenshot5
It is a production site, that has debug information in the console being printed out, this is consuming resources on every clients browser. While it doesnt affect you directly, it does run computer code on every clients browser, which is not very eco friendly.

SPL: 2TooLbSn4wySZPwyprTXuJUp7vByhVqB1yArrwndXpSo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant