Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale bar #129

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Scale bar #129

wants to merge 4 commits into from

Conversation

diegoasua
Copy link
Member

This PR adds a scale bar functionality to the viewer via the napari.Viewer.scalebar() which is itself implemented as an EventedModel in Napari . Display of scale bar is optional - can by showed/hidden with a QPushButton in ViewingWidget. Display is independent of the mode, and in 3d display mode as well (this is actually completely useless in the current state). Scale is in um as defined by voxel_size property of ViewingWidget. Unit display is not yet available from Napari but there are plans to include this soon(ish).

In pixel units, with show/hide pushbutton
Supports pixel size, without units
… scale_bar

# Conflicts:
#	sashimi/processes/streaming_save.py
@diegoasua diegoasua linked an issue Feb 22, 2021 that may be closed by this pull request
@diegoasua diegoasua requested a review from vigji February 22, 2021 00:17
Copy link
Member

@vigji vigji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, I would merge after trying it out!

@diegoasua
Copy link
Member Author

Finally, scale bar also displays units

@diegoasua
Copy link
Member Author

diegoasua commented Mar 1, 2021

Not sure how to fix the inheritance validator error from the CI agent. It clearly oversmarted us here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scale bar to viewer
2 participants