Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop color.link #26

Open
gadenbuie opened this issue Oct 15, 2024 · 0 comments
Open

Drop color.link #26

gadenbuie opened this issue Oct 15, 2024 · 0 comments

Comments

@gadenbuie
Copy link
Collaborator

Similar to #24, the presence of color.link is confusing considering that we also have typography.link.color.

This would result in a change like the following for a theoretical _brand.yml

color:
  palette:
    red: "#FF6F61"
- link: red
typography:
  link:
    weight: 600
-   color: link
+   color: red
    decoration: underline
@gadenbuie gadenbuie mentioned this issue Oct 16, 2024
Open
gadenbuie added a commit that referenced this issue Oct 16, 2024
@gadenbuie
chore(color): Drop emphasis and link from color
3d33f18 
Drop `color.emphasis` #24
Drop `color.link` #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gadenbuie