Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple Stub responsibilities from Boxhead ones #517

Open
rich-iannone opened this issue Nov 21, 2024 · 0 comments
Open

Decouple Stub responsibilities from Boxhead ones #517

rich-iannone opened this issue Nov 21, 2024 · 0 comments

Comments

@rich-iannone
Copy link
Member

Currently the Boxhead uses the Stub in only one method. If we remove that dependency, it will be much more that the Stub drives the Boxhead. In the rendering code, we look at both the Boxhead and the Stub, when we could instead just use the Boxhead.

There are a few ways to decouple the Stub from the Boxhead:

  • _get_effective_number_of_columns() method of Boxhead could instead be replaced use final_columns()
  • enumerate where final_columns() should be used in the rendering code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant