You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In PR #499 we replaced saving to a temporary file with inputting base64 encoded rendered html into a headless browser.
Browser url limits are a bit tricky, but they do exist. Let's investigate potential issues we might hit by passing long urls to the headless browser.
Alternatively, it might save us time to revert back to saving a temporary file, since the gt R package has used that approach for ~6 years with little issue.
I would vote for reverting, just to align with gt R. It's likely modern browsers have large url limits, but it's tricky to verify.
The text was updated successfully, but these errors were encountered:
In PR #499 we replaced saving to a temporary file with inputting base64 encoded rendered html into a headless browser.
Browser url limits are a bit tricky, but they do exist. Let's investigate potential issues we might hit by passing long urls to the headless browser.
Alternatively, it might save us time to revert back to saving a temporary file, since the gt R package has used that approach for ~6 years with little issue.
I would vote for reverting, just to align with gt R. It's likely modern browsers have large url limits, but it's tricky to verify.
The text was updated successfully, but these errors were encountered: