Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save: investigate use of base64 encoded urls in headless browser #518

Open
machow opened this issue Nov 22, 2024 · 1 comment
Open

save: investigate use of base64 encoded urls in headless browser #518

machow opened this issue Nov 22, 2024 · 1 comment

Comments

@machow
Copy link
Collaborator

machow commented Nov 22, 2024

In PR #499 we replaced saving to a temporary file with inputting base64 encoded rendered html into a headless browser.

Browser url limits are a bit tricky, but they do exist. Let's investigate potential issues we might hit by passing long urls to the headless browser.

Alternatively, it might save us time to revert back to saving a temporary file, since the gt R package has used that approach for ~6 years with little issue.

I would vote for reverting, just to align with gt R. It's likely modern browsers have large url limits, but it's tricky to verify.

@jrycw
Copy link
Collaborator

jrycw commented Nov 22, 2024

@machow , I wasn’t aware of this issue. Please feel free to revert to the temporary file approach if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants