Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Permission.create(principal:User | Group) support #343

Merged
merged 8 commits into from
Dec 5, 2024
Merged

feat: Add Permission.create(principal:User | Group) support #343

merged 8 commits into from
Dec 5, 2024
+167 −15

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Nov 19, 2024 •
edited
Loading

Fixes #342
Related: https://github.com/rstudio/connect/issues/28825

@schloerke schloerke self-assigned this Nov 19, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 19, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1885 1745 93% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/posit/connect/permissions.py 96% 🟢
TOTAL 96% 🟢

updated for commit: 7938804 by action🐍

@schloerke schloerke requested a review from jonkeane November 20, 2024 16:06
@schloerke
Copy link
Collaborator Author

@jonkeane Looking for approval on the function implementation. I'll add unit testing after #339 is merged and ask again for a review before merging.

@schloerke schloerke mentioned this pull request Nov 22, 2024
Merged
toph-allen
toph-allen approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@toph-allen toph-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pair reviewed. Approved given the small doc changes :)

src/posit/connect/permissions.py Outdated Show resolved Hide resolved
src/posit/connect/permissions.py Outdated Show resolved Hide resolved
@toph-allen toph-allen mentioned this pull request Dec 2, 2024
Merged
@schloerke schloerke marked this pull request as ready for review December 3, 2024 16:16
@schloerke schloerke requested a review from tdstein as a code owner December 3, 2024 16:16
@toph-allen toph-allen marked this pull request as draft December 3, 2024 19:03
@schloerke schloerke marked this pull request as ready for review December 5, 2024 18:16
@schloerke
Copy link
Collaborator Author

Reviewed in person w/ @toph-allen . Merging

@schloerke schloerke merged commit b884e65 into main Dec 5, 2024
35 checks passed
@schloerke schloerke deleted the schloerke/342-add-user-group-permission branch December 5, 2024 18:33
@schloerke schloerke changed the title feat: Add Permission.create(*args:User | Group) support feat: Add Permission.create(principal:User | Group) support Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toph-allen toph-allen toph-allen approved these changes

@jonkeane jonkeane jonkeane left review comments

@amol- amol- amol- left review comments

@tdstein tdstein Awaiting requested review from tdstein tdstein is a code owner

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add users and groups to content item permissions
4 participants
@schloerke @amol- @jonkeane @toph-allen