From a181837fc1d5fd55f7ed377d89d3fce286a318d7 Mon Sep 17 00:00:00 2001 From: Daniel Falbel Date: Thu, 21 Nov 2024 21:41:51 -0300 Subject: [PATCH] Special case reticulate for the old supervisor (#5438) This special cases reticulate so the Python session is started with the old jupyter supervisor while we don't implement https://github.com/posit-dev/positron/issues/5226 If we don't do this, reticulate will try to use the new supervisor (because it forwards to `PythonRuntimeSession.start()`) and users will see a: ![image](https://github.com/user-attachments/assets/8f652b87-9a85-4bc4-952f-f33f0e3309b5) ``` socket hang up ``` ### QA Notes Now reticulate should work even if Positron is configured to use the new supervisor: ![image](https://github.com/user-attachments/assets/96518697-88ad-4963-a017-7e294660a002) --- extensions/positron-python/src/client/positron/session.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/positron-python/src/client/positron/session.ts b/extensions/positron-python/src/client/positron/session.ts index fc518bceb94..e25655204d6 100644 --- a/extensions/positron-python/src/client/positron/session.ts +++ b/extensions/positron-python/src/client/positron/session.ts @@ -437,7 +437,7 @@ export class PythonRuntimeSession implements positron.LanguageRuntimeSession, vs private async createKernel(): Promise { const config = vscode.workspace.getConfiguration('positronKernelSupervisor'); - if (config.get('enable', true)) { + if (config.get('enable', true) && this.runtimeMetadata.runtimeId !== 'reticulate') { // Use the Positron kernel supervisor if enabled const ext = vscode.extensions.getExtension('vscode.positron-supervisor'); if (!ext) {