-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python line-by-line execution fails to detect closing paren #1811
Comments
I'm happy to look into this next, after finishing off my current work on improved support in Positron for the This is related to #1260, and seems to be the same bug as described in #1260 (comment). We could extend our current Python statement range provider to fix these issues, but a more robust course of action may be to look into plumbing into the Python extension's new "smart send" feature as suggested in #1260 (comment). Here's the PR that introduced that: microsoft/vscode-python#21779. |
I would agree that the best thing to do here is plumb in the Python extensions "smart send" |
…er statement range detection Merge pull request #259 from posit-dev/smart-send Use "smart send" for Cmd+Enter statement range detection -------------------- Commit message for posit-dev/positron-python@8a7f634: fix merge issues -------------------- Commit message for posit-dev/positron-python@a6ead38: Merge remote-tracking branch 'origin/main' into smart-send -------------------- Commit message for posit-dev/positron-python@96f3ed2: fix excluding closing token Addresses #1811. -------------------- Commit message for posit-dev/positron-python@7872ce0: use smart send feature in positron statement range provider Authored-by: Wasim Lorgat <[email protected]> Signed-off-by: Wasim Lorgat <[email protected]>
…er statement range detection Merge pull request #259 from posit-dev/smart-send Use "smart send" for Cmd+Enter statement range detection -------------------- Commit message for posit-dev/positron-python@8a7f634: fix merge issues -------------------- Commit message for posit-dev/positron-python@a6ead38: Merge remote-tracking branch 'origin/main' into smart-send -------------------- Commit message for posit-dev/positron-python@96f3ed2: fix excluding closing token Addresses #1811. -------------------- Commit message for posit-dev/positron-python@7872ce0: use smart send feature in positron statement range provider Authored-by: Wasim Lorgat <[email protected]> Signed-off-by: Wasim Lorgat <[email protected]>
For this code:
If I attempt to execute line-by-line, when I get tot the third line the text passed to the console does not include the trailing paren (so it doesn't execute):
The text was updated successfully, but these errors were encountered: