Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot scroll through all options in dialog (cut off by Positron window size) #3061

Open
juliasilge opened this issue May 8, 2024 · 3 comments
Assignees
Labels
area: project wizard Issues related to New Project Wizard category. area: ui Issues related to UI category. bug Something isn't working frontend Issues having to do with the frontend (Electron) part of a category sharp-edge

Comments

@juliasilge
Copy link
Contributor

Positron Version:

2024.05.0 (Universal) build 1157

Steps to reproduce the issue:

  1. Bring up some data in the Data Explorer that has a lot of columns, such as with View(nycflights13::flights)
  2. Resize the Positron window to be pretty small
  3. Try to scroll through the column names in a column filter
  4. You cannot scroll through all of them with your mouse, and if you try with arrow keys, you can't see what you might be selecting.
dialogs.mov

What did you expect to happen?

I expected to be able to scroll through all the options in a menu. This looks related to the problem I describe for the New Project Wizard in #2982 (comment), so maybe this is a problem for all our dialogs.

Were there any error messages in the output or Developer Tools console?

None that look related.

@juliasilge juliasilge added bug Something isn't working area: ui Issues related to UI category. labels May 8, 2024
@sharon-wang
Copy link
Member

The dropdowns used in the New Project modal use the general-purpose DropDownListBox component, which is based on a ModalPopup component. The dropdowns related to filtering the data grid use a different component also based on ModalPopup.

We'll need to expand on the ModalPopup to support resizing according to different window sizes, which I think this issue focuses on. This issue and the behaviour mentioned in #2982 cover the vertical overflow of dropdown content. There are also some instances of horizontal overflow of content, but I don't recall which usages of the dropdown components are affected 😓

We may want to open a separate issue for the DropDownListBox to include scroll and search support (that functionality is only available in the data grid filter dropdowns currently).

CC @softwarenerd for awareness! I think we also discussed pulling the data grid filter dropdown functionality into a more general-purpose component, so both DropDownListBox and something like DropDownComboBox can be used outside of the data grid.

@juliasilge
Copy link
Contributor Author

There is a similar problem with dialogs that go out of the Positron window horizontally:

Screenshot 2024-05-09 at 5 20 42 PM

@petetronic petetronic added the frontend Issues having to do with the frontend (Electron) part of a category label May 13, 2024
@petetronic petetronic added this to the Public Beta 2024 Q2 milestone May 13, 2024
@sharon-wang sharon-wang added the area: project wizard Issues related to New Project Wizard category. label May 30, 2024
@sharon-wang
Copy link
Member

Wasim noted that the Project Wizard interpreter dropdown wasn't showing in #5502. I was able to reproduce the issue in a few different dropdowns in 2024.12.0-41 when the vertical space in the IDE is limited.

In particular, for the Project Wizard interpreter dropdown, there was still a good amount of vertical real estate -- I expected the dropdown to show and possibly to become a scrollable dropdown.

Project Wizard interpreter dropdown not showing when vertical space limited

proj_wiz_dropdown_not_expanding.mp4

Checking other dropdowns in Positron

  • Save Plots modal dialog -- image type dropdown not showing when vertical space limited
  • Interpreter Dropdown seems okay!
  • Data Explorer
    • Column name filter dropdown seems okay!
    • Column condition filter dropdown not showing when vertical space limited
dropdown_not_enough_vertical_space.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: project wizard Issues related to New Project Wizard category. area: ui Issues related to UI category. bug Something isn't working frontend Issues having to do with the frontend (Electron) part of a category sharp-edge
Projects
None yet
Development

No branches or pull requests

5 participants