Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Explorer: Decimal alignment is off for R #3175

Closed
jthomasmock opened this issue May 17, 2024 · 5 comments
Closed

Data Explorer: Decimal alignment is off for R #3175

jthomasmock opened this issue May 17, 2024 · 5 comments
Assignees
Labels
area: data explorer Issues related to Data Explorer category. bug Something isn't working lang: r

Comments

@jthomasmock
Copy link
Contributor

Positron Version: 2024.05.0 (Universal) build 1255

Code - OSS Version: 1.89.0
Commit: a60c905
Date: 2024-05-16T03:42:49.370Z
Electron: 28.2.8
Chromium: 120.0.6099.291
Node.js: 18.18.2
V8: 12.0.267.19-electron.0
OS: Darwin arm64 23.4.0

Steps to reproduce the issue:

  1. View(mtcars)
  2. Note that decimal alignment is off and there isn't a decimal place unless a significant figure past the decimal is present, ie 24 vs 24.

image

What did you expect to happen?

We should enforce decimal alignment at the least, and/or force additional digits for alignment.

Were there any error messages in the output or Developer Tools console?

@jthomasmock jthomasmock added bug Something isn't working area: data explorer Issues related to Data Explorer category. lang: r labels May 17, 2024
@jthomasmock jthomasmock added this to the Public Beta 2024 Q2 milestone May 17, 2024
@dfalbel
Copy link
Contributor

dfalbel commented May 31, 2024

For beta, this will be implementing the R side of #3310

@jthomasmock
Copy link
Contributor Author

Hey @dfalbel -- was that PR part of #3479? I was hoping to try this out in dev branch 🙏

@dfalbel
Copy link
Contributor

dfalbel commented Jun 11, 2024

Not yet @jthomasmock, this will be fixed in posit-dev/ark#382, but it's not merged yet

@jthomasmock
Copy link
Contributor Author

Not yet @jthomasmock, this will be fixed in posit-dev/amalthea#382, but it's not merged yet

Thanks for update!

@testlabauto
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2024.06.0-770
OS Version          : OSX

Test scenario(s)

Alignment looks good (.00 added to whole numbers to create alignment)

Link(s) to TestRail test cases run or created:

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: data explorer Issues related to Data Explorer category. bug Something isn't working lang: r
Projects
None yet
Development

No branches or pull requests

3 participants