Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Red square ("busy indicator") missing? #5724

Closed
strengejacke opened this issue Dec 13, 2024 · 4 comments
Closed

Red square ("busy indicator") missing? #5724

strengejacke opened this issue Dec 13, 2024 · 4 comments
Labels
area: console Issues related to Console category. area: ui Issues related to UI category. bug Something isn't working regression support

Comments

@strengejacke
Copy link

Not sure if this was intentional, but in previous Positron versions, there was a res square in the upper right corner, indicating when R console was busy:

Image

This is missing in the latest version - was this change intentional?

Positron Version: 2025.01.0 (system setup) build 39
Code - OSS Version: 1.93.0
Commit: c7ef34f
Date: 2024-12-09T02:44:40.379Z
Electron: 30.4.0
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Windows_NT x64 10.0.26100
@jennybc
Copy link
Member

jennybc commented Dec 13, 2024

Yes, I agree it seems to have gone missing. I'm going to initiate a search for the 🟥 button!

Sidebar: it is sort of a busy indicator, but its real purpose is to try to interrupt the computation, if the user clicks it.

@jennybc jennybc added regression area: console Issues related to Console category. area: ui Issues related to UI category. labels Dec 13, 2024
@strengejacke
Copy link
Author

strengejacke commented Dec 13, 2024 •
edited
Loading

but its real purpose is to try to interrupt the computation

Yes, you're right. The busy indicator is more the green border left of the console. It's the equivalent to the RStudio stop button.

@juliasilge juliasilge added bug Something isn't working support labels Dec 13, 2024
@jennybc
Copy link
Member

jennybc commented Dec 13, 2024

I did a manual bisect investigation using the private pre-release builds. I can narrow it down to these 3 commits, of which 59b5b0c sure looks the most related to this matter 🧐:

3d0cc41...59b5b0c

Button is last present in 2024.12.0-48:
Positron Version: 2024.12.0 (Universal) build 48
Code - OSS Version: 1.93.0
Commit: 3d0cc41
Date: 2024-11-20T02:45:46.693Z

In the next pre-release build, 2024.12.0-51, button is gone:
Positron Version: 2024.12.0 (Universal) build 51
Code - OSS Version: 1.93.0
Commit: 59b5b0c
Date: 2024-11-21T02:46:07.218Z

@jmcphers jmcphers mentioned this issue Dec 13, 2024
Merged
jmcphers added a commit that referenced this issue Dec 13, 2024
@jmcphers
Fix missing Interrupt button (render children of ActionBarButton) (#5732
1581d96 
)

This fixes an issue in which the Interrupt/Stop button disappeared from
the Console. The problem appears to be that the `ActionBarButton` does
not render its child elements when it has no dropdown indicator. The fix
is to render them beneath the button face in this situation.

Addresses #5724.

### QA Notes

This is only one line of code, but could affect any button in the UI.
@testlabauto
Copy link
Contributor

Verified Fixed

Positron Version(s) : 2025.01.0-104
OS Version          : OSX

Test scenario(s)

Works with a simple sleep.
Also validated in automation now.

Link(s) to TestRail test cases run or created:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: console Issues related to Console category. area: ui Issues related to UI category. bug Something isn't working regression support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jennybc @juliasilge @strengejacke @testlabauto