Settings: Improve titles #5791
Draft
Settings: Improve titles #5791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
|
To make it easier to review this PR, I would recommend hiding whitespace to only see relevant changes to updating setting titles. |
dhruvisompura
commented
Dec 18, 2024
| "r.configuration.title": "Positron R Language Pack", | ||
| "r.configuration.title-dev": "Positron R Language Pack (advanced)", | ||
| "r.configuration.title": "R", | ||
| "r.configuration.title-dev": "Advanced Settings", |
There was a problem hiding this comment.
I am considering changing this title to: Advanced since the Settings portion is a bit redundant. Let me know if anyone strongly disagrees. The contribution point docs mention avoiding these terms since they are redundant as well: https://code.visualstudio.com/api/references/contribution-points#contributes.configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addressess #1487
This is a first pass at improving the setting titles displayed in the settings table of contents for built in positron extensions. Any titles prefixed with "Positron" has been removed and ambiguity in extension titles have been addressed. The setting title in the TOC and category title for each setting item has been unified to match where possible. configuration keys have been changed to fix formatting of setting categories where possible.
Extension configuration keys that are prefixed with
positronhave been left as is for now (excluding theInterpreter settings) since the prefix does not effect the settings UI for now. We may want to address improving the key names for folks who interact with settings via the JSON file. It may be worth tackling after settling on a standard for configuration name formatting for bundled extensions.The "Positron > Interpreters" settings now live under "Interpreters"/
The following extensions were modified and have the following setting titles in the TOC:
QA Notes
We'll want to verify there aren't any regressions with the settings for the extensions listed above, excluding any experimental feature settings.
For the interpreter settings we should verify that changing the automatic startup behavior, restart on crash behavior, and viewing sessions for interpreters are respected as usual.
Screenshots
Screen.Recording.2024-12-17.at.4.06.04.PM.mov