From 5bd50bc4a7d2d9d08801e3d0c91e3b02ee31c134 Mon Sep 17 00:00:00 2001 From: Julia Silge Date: Mon, 25 Nov 2024 11:32:57 -0700 Subject: [PATCH 1/2] Add more logging for Python interpreter discovery --- extensions/positron-python/src/client/positron/session.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/extensions/positron-python/src/client/positron/session.ts b/extensions/positron-python/src/client/positron/session.ts index e25655204d6..400635e261f 100644 --- a/extensions/positron-python/src/client/positron/session.ts +++ b/extensions/positron-python/src/client/positron/session.ts @@ -107,7 +107,10 @@ export class PythonRuntimeSession implements positron.LanguageRuntimeSession, vs const interpreter = interpreterService.getInterpreters().find((i) => i.id === extraData.pythonEnvironmentId); if (!interpreter) { - throw new Error(`Interpreter not found: ${extraData.pythonEnvironmentId}`); + const interpreterIds = interpreterService.getInterpreters().map((i) => `${i.id}`); + throw new Error( + `Interpreter ${extraData.pythonEnvironmentId} not found in available Python interpreters: ${interpreterIds}`, + ); } this.interpreter = interpreter; From 3e9a26afed554f3a042f136922a2361943b73e46 Mon Sep 17 00:00:00 2001 From: Julia Silge Date: Wed, 27 Nov 2024 11:27:54 -0700 Subject: [PATCH 2/2] Apply suggestions from code review by @sharon-wang Co-authored-by: sharon Signed-off-by: Julia Silge --- extensions/positron-python/src/client/positron/session.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/extensions/positron-python/src/client/positron/session.ts b/extensions/positron-python/src/client/positron/session.ts index 400635e261f..8103e86d2ed 100644 --- a/extensions/positron-python/src/client/positron/session.ts +++ b/extensions/positron-python/src/client/positron/session.ts @@ -107,9 +107,9 @@ export class PythonRuntimeSession implements positron.LanguageRuntimeSession, vs const interpreter = interpreterService.getInterpreters().find((i) => i.id === extraData.pythonEnvironmentId); if (!interpreter) { - const interpreterIds = interpreterService.getInterpreters().map((i) => `${i.id}`); + const interpreterIds = interpreterService.getInterpreters().map((i) => `\n- ${i.id}`); throw new Error( - `Interpreter ${extraData.pythonEnvironmentId} not found in available Python interpreters: ${interpreterIds}`, + `Interpreter ${extraData.pythonEnvironmentId} (path: ${extraData.pythonPath}) not found in available Python interpreters: ${interpreterIds}`, ); } this.interpreter = interpreter;