Merge pull request #2167 from posit-dev/remove-some-straggling-throws

Remove some throws which were left in the web view
posit-dev · Aug 23, 2024 · 3325457 · 3325457
2 parents 0c7f618 + 72cc47f
commit 3325457
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/extensions/vscode/webviews/homeView/src/HostConduitService.ts b/extensions/vscode/webviews/homeView/src/HostConduitService.ts
@@ -38,9 +38,10 @@ export function useHostConduitService() {
 
   const sendMsg = (msg: WebviewToHostMessage) => {
     if (!hostConduit) {
-      throw new Error(
-        "HostCondiutService::sendMsg attemped ahead of call to useHostConduitService",
+      console.error(
+        `HostCondiutService::sendMsg attempted ahead of call to useHostConduitService. Message Dropped: ${JSON.stringify(msg)}`,
       );
+      return;
     }
     console.debug(`HostConduitService - Sending Msg: ${JSON.stringify(msg)}`);
     return hostConduit.sendMsg(msg);

diff --git a/extensions/vscode/webviews/homeView/src/components/DeployButton.vue b/extensions/vscode/webviews/homeView/src/components/DeployButton.vue
@@ -39,9 +39,10 @@ const deploy = () => {
     !home.selectedConfiguration ||
     !home.serverCredential
   ) {
-    throw new Error(
-      "DeployButton::deploy trying to send message with undefined values",
+    console.error(
+      "DeployButton::deploy trying to send message with undefined values. Action ignored.",
     );
+    return;
   }
 
   hostConduit.sendMsg({

diff --git a/extensions/vscode/webviews/homeView/src/utils/hostConduit.ts b/extensions/vscode/webviews/homeView/src/utils/hostConduit.ts
@@ -23,7 +23,10 @@ export class HostConduit {
       if (isHostToWebviewMessage(obj)) {
         this.externalMsgCB(obj);
       } else {
-        throw new Error(`NonConduitMessage Received: ${JSON.stringify(e)}`);
+        console.error(
+          `HostConduit::rawMsgCB, NonConduitMessage Received: ${JSON.stringify(e)}`,
+        );
+        return;
       }
     }
   };