Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is failing on main due to flake8 #1010

Closed
nealrichardson opened this issue Jan 16, 2024 · 0 comments · Fixed by #1012
Closed

CI is failing on main due to flake8 #1010

nealrichardson opened this issue Jan 16, 2024 · 0 comments · Fixed by #1012
Assignees

Comments

@nealrichardson
Copy link
Collaborator

See https://github.com/posit-dev/py-shiny/actions/runs/7538643088/job/20519572273 for example

flake8 --show-source .
./shiny/_utils.py:396:13: B036 Don't except `BaseException` unless you plan to re-raise it.
            except BaseException as e:
            ^
./shiny/_utils.py:422:9: B036 Don't except `BaseException` unless you plan to re-raise it.
        except BaseException as e:
        ^
./shiny/render/renderer/_renderer.py:228:13: B037 Class `__init__` methods must not return or yield and any values.
            return cast(AsyncValueFn[IT], fn)
            ^
@schloerke schloerke self-assigned this Jan 16, 2024
@wch wch mentioned this issue Jan 16, 2024
@wch wch closed this as completed in #1012 Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants