Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade App's UI function to async #968

Open
schloerke opened this issue Jan 4, 2024 · 0 comments
Open

Upgrade App's UI function to async #968

schloerke opened this issue Jan 4, 2024 · 0 comments

Comments

@schloerke
Copy link
Collaborator

Would allow for app authors to make async calls within their UI function.

From what I can see,

ui = self._render_page(self.ui(request), self.lib_prefix)
is the only place it is executed and is already within an async function.

We could wrap it in async at the very beginning, avoiding repeated is async checks.

@schloerke schloerke modified the milestones: v0.7.0, v0.8.0 Jan 16, 2024
@wch wch removed this from the v0.8.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants