You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Given #119, register_widget() does not follow the Shiny rendering pattern.
Current (inside server body):
map=create_map(layout=ipywidgets.Layout(width="100%", height="100%"))
map_widget=register_widget("map", map)
map_widget# do stuff
Proposed:
map_val=create_map(layout=ipywidgets.Layout(width="100%", height="100%"))
@render_widgetdefmap():
returnmap_valmap.widget# do stuff
While the Current approach is tighter and requires less lines, calling a register method doesn't tell me that it's going to be rendered to the UI.
With more render methods with full typing in the near future, I'd recommend that register_widget be deprecated in favor of the standard Shiny approach.
The text was updated successfully, but these errors were encountered:
Given #119,
register_widget()
does not follow the Shiny rendering pattern.Current (inside
server
body):Proposed:
While the Current approach is tighter and requires less lines, calling a register method doesn't tell me that it's going to be rendered to the UI.
With more render methods with full typing in the near future, I'd recommend that
register_widget
be deprecated in favor of the standard Shiny approach.The text was updated successfully, but these errors were encountered: