Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should remove actions.deploy_python_fastapi #573

Open
wch opened this issue Apr 5, 2024 · 0 comments
Open

Should remove actions.deploy_python_fastapi #573

wch opened this issue Apr 5, 2024 · 0 comments

Comments

@wch
Copy link
Collaborator

wch commented Apr 5, 2024

The function actions.deploy_python_fastapi is a deprecated code path, and many similar functions were removed in #566. This function was kept because it is used by vetiver here.

At some point, we should:

  • Replace actions.deploy_python_fastapi with one that calls the python fastapi deployment code in main.py.
  • Update vetiver to call the function from main.py.
  • After some time, remove actions.deploy_python_fastapi.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant