Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updatte codeblock-to-json.ts to match new Quarto behaviour #185

Open
kv9898 opened this issue Oct 30, 2024 · 2 comments
Open

Updatte codeblock-to-json.ts to match new Quarto behaviour #185

kv9898 opened this issue Oct 30, 2024 · 2 comments
Assignees

Comments

@kv9898
Copy link

kv9898 commented Oct 30, 2024

Also at quarto-ext/shinylive#65

In the current implementation, codeblock-to-json.ts uses:

import { readLines } from "https://deno.land/std/io/mod.ts";

Quarto 1.6 introduced breaking changes, which require an update in the code in favour of sth like:

import { readLines } from "stdlib/io";
@georgestagg
Copy link
Collaborator

As mentioned in the linked thread, this will require some thought to handle both the breaking change in Quarto and older versions. We might require two scripts and use the correct one based on quarto version.

@georgestagg
Copy link
Collaborator

My understanding is that this should now be working again in the latest Quarto builds.

We should leave this open for the moment, however, since it's possible Quarto might re-enable the use of --cached-only in the future and if so our script will break again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants