Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Integrate a spinner to track time taken for long running operations. #679

Closed
kishen-v opened this issue Oct 3, 2024 · 6 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kishen-v
Copy link
Contributor

kishen-v commented Oct 3, 2024

What happened:
Multiple logs with the same message is printed on screen which is redundant by nature, a spinner can be used to achieve the objective.

I0927 03:24:02.531498  835123 import.go:258] Importing image rhel-94-04242024-tier0. Please wait...
I0927 03:24:06.596504  835123 import.go:277] Image import is in-progress, current state: queued
I0927 03:26:06.680951  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:28:06.623011  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:30:06.843204  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:32:06.727223  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:34:06.769074  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:36:06.920080  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:38:06.861958  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:40:06.951969  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:42:06.826810  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:44:06.873676  835123 import.go:277] Image import is in-progress, current state: running
I0927 03:46:06.901292  835123 import.go:271] Image imported successfully, took 22m0.670579377s

Rather a spinner can be set-up lo track the current status and the time elapsed to improve user experience.

What you expected to happen:
A single line of log to track the status.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • pvsadm version (use pvsadm --version):
  • Environment - On-Prem or IBM PowerVS:
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Others:
@kishen-v kishen-v added the kind/bug Categorizes issue or PR as related to a bug. label Oct 3, 2024
@kishen-v
Copy link
Contributor Author

kishen-v commented Oct 3, 2024

/remove-kind bug
/kind feature
/good-first-issue

@ppc64le-cloud-bot
Copy link
Contributor

@kishen-v:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/remove-kind bug
/kind feature
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ppc64le-cloud-bot ppc64le-cloud-bot added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed kind/bug Categorizes issue or PR as related to a bug. labels Oct 3, 2024
@kishen-v
Copy link
Contributor Author

kishen-v commented Oct 3, 2024

cc: @priyanshikhetwani

@priyanshikhetwani
Copy link
Contributor

/assign

@kishen-v
Copy link
Contributor Author

Fixed via #680.
/close

@ppc64le-cloud-bot
Copy link
Contributor

@kishen-v: Closing this issue.

In response to this:

Fixed via #680.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants