Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing features for prediction #34

Open
ppdebreuck opened this issue Feb 22, 2021 · 2 comments
Open

missing features for prediction #34

ppdebreuck opened this issue Feb 22, 2021 · 2 comments

Comments

@ppdebreuck
Copy link
Owner

If some features are missing (from the optimal ones), when featurizing novel compounds (for predicting stage), predict() will not work. This happens for instance when some elements are not present in this prediction set, and corresponding features are thus not generated, but could have been selected during training.

@ppdebreuck
Copy link
Owner Author

Issue still present - can now be elegantly fixed by using (or adapting) our Imputer to remember and impute missing features needed for prediction.
Sidenotes:

  • It would be better though that non-existing features (such as Miedema statistics) are fixed at the root (either update matminer or not use at all).
  • Imputation might be feature dependent... case (i) as above: unknown: replace by mean, -1,... Case (ii): missing but known: e.g. Element Fraction of missing element: obviously 0.

@ppdebreuck
Copy link
Owner Author

Tagging @gbrunin as partially involved in this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant